Fix GH-15123: var_dump doesn't actually work on XMLReader #15130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 28, 2024
Perhaps uninitialized isn't the right word. The error basically happens because you're reading a the |
|
Ah okay, yeah I think the error wording maybe should be improved then, as I thought it was similar to a DateTime object not being properly initialized |
Girgias
approved these changes
Jul 28, 2024
|
What about something like "Failed to read property because no XML data has been read yet" ? |
|
I think that is indeed a better error message! :) |
Girgias
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting master because it changes long standing behaviour, although what it currently does is useless anyway...